Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing RCT_DEV_KEY_COMMANDS to disable RCTKeyCommands #46692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Introducing RCT_DEV_KEY_COMMANDS to disable RCTKeyCommands #46692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
custom macro to disable RCTKeyCommands
@343max
343max committed Sep 27, 2024
commit 1c40a03689911142b7d2c44a71a51c4eb8410498
8 changes: 8 additions & 0 deletions packages/react-native/React/Base/RCTDefines.h
View file
Original file line number Diff line number Diff line change
@@ -91,6 +91,14 @@
#define RCT_DEV_MENU RCT_DEV
#endif

/**
* Setting RCT_DEV_KEY_COMMANDS to 0 allows apps with RCT_DEV enabled to be
* distributed to developers via TestFlight.
*/
#ifndef RCT_DEV_KEY_COMMANDS
#define RCT_DEV_KEY_COMMANDS RCT_DEV
#endif

#ifndef RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION
#if RCT_DEV && (__has_include("RCTPackagerConnection.h") || __has_include(<React/RCTPackagerConnection.h>))
#define RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION 1
2 changes: 1 addition & 1 deletion packages/react-native/React/Base/RCTKeyCommands.m
View file
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@
#import "RCTDefines.h"
#import "RCTUtils.h"

#if RCT_DEV
#if RCT_DEV_KEY_COMMANDS

@interface UIEvent (UIPhysicalKeyboardEvent)

Loading