fix: fix @react-native-community/cli-platform-* packages not being found in monorepos
#47308
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…found in pnpm setups
facebook-github-bot
added
CLA Signed
33 tasks
tido64
changed the title
@react-native-community/cli-platform-* packages not being found in pnpm setups@react-native-community/cli-platform-* packages not being found in monorepos
tido64
force-pushed
the
tido/fix-rncli-pnpm-2
branch
from
9d3672a to
01e7c20
Compare
tido64
force-pushed
the
tido/fix-rncli-pnpm-2
branch
from
01e7c20 to
3e56095
Compare
robhogan
approved these changes
Feb 11, 2025
Thanks for adding that comment - I don't love this assumption, but on the basis that the CLI is already making it, I'm OK building on it and calling this non-breaking. I think we should investigate using an optional peer dependency here though - the sticking point might be the number of non-CLI users on Yarn classic. |
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @tido64 in 7926d65 When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
…found in monorepos (#47308) Summary: Fix `react-native-community/cli-platform-*` packages not being found in monorepos. Note that we are making the assumption that `process.cwd()` returns the project root. This is the same assumption that `react-native-community/cli` makes. Specifically, `findProjectRoot()` has an optional argument that defaults to `process.cwd()`: - [`findProjectRoot()`](https://github.com/react-native-community/cli/blob/14.x/packages/cli-tools/src/findProjectRoot.ts) - Which gets called without arguments in [`loadConfig()`](https://github.com/react-native-community/cli/blob/14.x/packages/cli-config/src/loadConfig.ts#L89) - `loadConfig()` gets called from [`setupAndRun()`](https://github.com/react-native-community/cli/blob/14.x/packages/cli/src/index.ts#L196), also without project root set As far as I can see, the project root argument is only ever used in tests. ## Changelog: [GENERAL] [FIXED] - Fix `react-native-community/cli-platform-*` packages not being found in monorepos Pull Request resolved: #47308 Test Plan: 1. Clone/check out this branch: microsoft/rnx-kit#3409 2. Cherry-pick #47304 3. Cherry-pick #47308 4. Run `react-native config` inside `packages/test-app` 5. Verify that `projects` is populated **Before:** ```js "healthChecks": [], "platforms": {}, "assets": [], "project": {} } ``` **After:** ```js "healthChecks": [], "platforms": { "ios": {}, "android": {} }, "assets": [], "project": { "ios": { "sourceDir": "/~/packages/test-app/ios", "xcodeProject": { "name": "SampleCrossApp.xcworkspace", "path": ".", "isWorkspace": true }, "automaticPodsInstallation": false, "assets": [] }, "android": { "sourceDir": "/~/packages/test-app/android", "appName": "app", "packageName": "com.msft.identity.client.sample.local", "applicationId": "com.msft.identity.client.sample.local", "mainActivity": "com.microsoft.reacttestapp.MainActivity", "assets": [] } } } ``` Reviewed By: cortinico Differential Revision: D69465533 Pulled By: robhogan fbshipit-source-id: 3d6cf32752a7a41d9c7e84f35b0f26ae7d7a971f
|
This pull request was successfully merged by @tido64 in ffe7bd1 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix
@react-native-community/cli-platform-*packages not being found in monorepos.Note that we are making the assumption that
process.cwd()returns the project root. This is the same assumption that@react-native-community/climakes. Specifically,findProjectRoot()has an optional argument that defaults toprocess.cwd():findProjectRoot()loadConfig()loadConfig()gets called fromsetupAndRun(), also without project root setAs far as I can see, the project root argument is only ever used in tests.
Changelog:
[GENERAL] [FIXED] - Fix
@react-native-community/cli-platform-*packages not being found in monoreposTest Plan:
react-nativeto 0.76 microsoft/rnx-kit#3409@react-native-community/clinot being found in monorepos #47304@react-native-community/cli-platform-*packages not being found in monorepos #47308react-native configinsidepackages/test-appprojectsis populatedBefore:
After: