Skip to content

feat(modal): [ios] dismissOnSwipeDown property #47398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mateoguzmana
Copy link
Collaborator

Summary:

Fixes #29319

This PR combines two fixes:

  • Currently, dismissing the modal by swiping down doesn't seem to work in Fabric. Probably was not ported over.
  • The only option to dismiss the modal available right now in Paper, always "stops" at the beginning before fully dragging down and there is no way to change that. This prop gives the option to allow fully dragging down.

This prop defaults to false to avoid introducing breaking changes. Fully optional.

Changelog:

[IOS] [ADDED] - Modal dismissOnSwipeDown property

Test Plan:

Video recording demonstrating how the prop behaves
420Screen.Recording.2024-11-05.at.00.46.58.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2024
@mateoguzmana mateoguzmana force-pushed the feat/allow-modal-dismissal-by-dragging-in-ios branch from 97c51b3 to 5ee9a0d Compare November 5, 2024 00:17
@mateoguzmana mateoguzmana marked this pull request as ready for review November 5, 2024 00:40
@mateoguzmana
Copy link
Collaborator Author

Well, while opening the PR, I found out there are other two PRs trying to solve a similar issue but not much activity on them lately – weren't linked to any of the issues I was tracking down so a bit easy to miss.

Leaving them here as reference:

Happy to help getting the ball rolling in any of them as well.

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 5, 2024
@mateoguzmana
Copy link
Collaborator Author

Closing in favour of the PRs that are still currently open aiming to fix the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS can't dismiss Modal!
2 participants