Migrate to UniformTypeIdentifiers #48623
Open
+16
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
woxtu
commented
Jan 12, 2025
| NSString *MIMEType = (__bridge_transfer NSString *)UTTypeCopyPreferredTagWithClass(UTI, kUTTagClassMIMEType); | ||
| NSString *MIMEType = [UTType typeWithIdentifier:(__bridge NSString *)UTI].preferredMIMEType; |
There was a problem hiding this comment.
'UTTypeCopyPreferredTagWithClass' is deprecated: first deprecated in iOS 15.0 - Use the UTType class instead.
woxtu
commented
Jan 12, 2025
| destination = CGImageDestinationCreateWithData(imageData, kUTTypePNG, 1, NULL); | ||
| destination = CGImageDestinationCreateWithData(imageData, (__bridge CFStringRef)UTTypePNG.identifier, 1, NULL); |
There was a problem hiding this comment.
'kUTTypePNG' is deprecated: first deprecated in iOS 15.0 - Use UTTypePNG or UTType.png (swift) instead.
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Thanks for fixing these warnings!
Unfortunately @woxtu, we need to wait a little before landing this change: internally we have a couple of apps that are still on iOS 13.4 and therefore we can't push this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR changes to use the Uniform Type Identifiers framework instead of the Mobile Core Services framework, and resolves deprecation warnings like the following:
Changelog:
[INTERNAL] [FIXED] - Migrate to UniformTypeIdentifiers
Test Plan: