Fix Nullsafe FIXMEs for StackTraceHelper.java and mark Nullsafe #50054
+59
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/StackTraceHelper.java Summary: Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable Changelog: [Internal] Differential Revision: D71126384
facebook-github-bot
added
CLA Signed
GijsWeterings
force-pushed
the
export-D71126387
branch
4 times, most recently
from
370b05a to
86dae6a
Compare
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made StackTraceHelper.java nullsafe Reviewed By: javache Differential Revision: D71126387
|
This pull request was exported from Phabricator. Differential Revision: D71126387 |
|
This pull request was exported from Phabricator. Differential Revision: D71126387 |
GijsWeterings
force-pushed
the
export-D71126387
branch
from
86dae6a to
fe5d24d
Compare
|
This pull request has been merged in 14de1c1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.
Changelog: [Android][Fixed] Made StackTraceHelper.java nullsafe
Reviewed By: javache
Differential Revision: D71126387