Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nullsafe FIXMEs for JSDebuggerWebSocketClient.java and mark nullsafe #50058

Closed
wants to merge 6 commits into from

Conversation

GijsWeterings
Copy link
Contributor

Summary:
Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385

…-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/StackTraceHelper.java

Summary:
Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable

Changelog: [Internal]

Differential Revision: D71126384
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71126385

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71126385

Summary:
Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made StackTraceHelper.java nullsafe

Differential Revision: D71126387
…-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/MultipartStreamReader.java

Summary:
Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable

Changelog: [Internal]

Differential Revision: D71126389
Summary:
Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made MultipartStreamReader.java nullsafe

Differential Revision: D71126393
…-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSDebuggerWebSocketClient.java

Summary:
Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable

Changelog: [Internal]

Differential Revision: D71126392
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…afe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 17, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
…afe (facebook#50058)

Summary:
Pull Request resolved: facebook#50058

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 18, 2025
…afe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
GijsWeterings added a commit to GijsWeterings/react-native that referenced this pull request Mar 18, 2025
…mark nullsafe (facebook#50058)

Summary:

Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.

Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe

Reviewed By: mdvacca

Differential Revision: D71126385
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 18, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3289569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants