Fix Nullsafe FIXMEs for DevServerHelper.java and mark nullsafe #50060
+80
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/StackTraceHelper.java Summary: Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable Changelog: [Internal] Differential Revision: D71126384
facebook-github-bot
added
the
CLA Signed
GijsWeterings
force-pushed
the
export-D71126391
branch
from
7bdf065 to
6bc0b45
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71126391 |
|
This pull request was exported from Phabricator. Differential Revision: D71126391 |
GijsWeterings
force-pushed
the
export-D71126391
branch
from
6bc0b45 to
92e0db3
Compare
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made StackTraceHelper.java nullsafe Differential Revision: D71126387
…-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/MultipartStreamReader.java Summary: Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable Changelog: [Internal] Differential Revision: D71126389
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made MultipartStreamReader.java nullsafe Differential Revision: D71126393
…-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSDebuggerWebSocketClient.java Summary: Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable Changelog: [Internal] Differential Revision: D71126392
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made JSDebuggerWebsocketClient.java nullsafe Differential Revision: D71126385
…-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java Summary: Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable Changelog: [Internal] Differential Revision: D71126395
GijsWeterings
force-pushed
the
export-D71126391
branch
from
92e0db3 to
aaf26c5
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 17, 2025
…ook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
|
This pull request was exported from Phabricator. Differential Revision: D71126391 |
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 17, 2025
…ook#50060) Summary: Pull Request resolved: facebook#50060 Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
GijsWeterings
force-pushed
the
export-D71126391
branch
2 times, most recently
from
571c2f2 to
5d5db28
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 17, 2025
…ook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 17, 2025
…afe (facebook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 17, 2025
…afe (facebook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 17, 2025
…afe (facebook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 17, 2025
…afe (facebook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 17, 2025
…afe (facebook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 17, 2025
…afe (facebook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 17, 2025
…afe (facebook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
…ook#50060) Summary: Pull Request resolved: facebook#50060 Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
|
This pull request was exported from Phabricator. Differential Revision: D71126391 |
GijsWeterings
force-pushed
the
export-D71126391
branch
from
5d5db28 to
e5edb65
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 18, 2025
…ook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Mar 18, 2025
…afe (facebook#50060) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe Reviewed By: rshest Differential Revision: D71126391
|
This pull request has been merged in 311cef3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.
Changelog: [Android][Fixed] Made DevServerHelper.java nullsafe
Reviewed By: rshest
Differential Revision: D71126391