Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/BundleDownloader.java #50065

Closed
wants to merge 13 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react…
…-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DebugOverlayController.java

Summary:
Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable

Changelog: [Internal]

Differential Revision: D71126397
GijsWeterings authored and facebook-github-bot committed Mar 17, 2025
commit bb45cd27d189b5f2f2a1d265e2f200f98507dc20
Original file line number Diff line number Diff line change
@@ -57,6 +57,7 @@ private static boolean hasPermission(Context context, String permission) {
PackageInfo info =
context
.getPackageManager()
// NULLSAFE_FIXME[Nullable Dereference]
.getPackageInfo(context.getPackageName(), PackageManager.GET_PERMISSIONS);
if (info.requestedPermissions != null) {
for (String p : info.requestedPermissions) {
@@ -73,6 +74,7 @@ private static boolean hasPermission(Context context, String permission) {

private static boolean canHandleIntent(Context context, Intent intent) {
PackageManager packageManager = context.getPackageManager();
// NULLSAFE_FIXME[Parameter Not Nullable]
return intent.resolveActivity(packageManager) != null;
}