Skip to content

Add CDP frame events #54249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+94 −1
Open

Add CDP frame events #54249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,66 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
.args = folly::dynamic::object("data", std::move(data)),
});
},
[&](PerformanceTracerSetLayerTreeIdEvent&& event) {
folly::dynamic data = folly::dynamic::object("frame", event.frame)(
"layerTreeId", event.layerTreeId);

events.emplace_back(TraceEvent{
.name = "SetLayerTreeId",
.cat = "devtools.timeline",
.ph = 'I',
.ts = event.start,
.pid = processId_,
.s = 't',
.tid = event.threadId,
.args = folly::dynamic::object("data", std::move(data)),
});
},
[&](PerformanceTracerFrameBeginDrawEvent&& event) {
folly::dynamic data = folly::dynamic::object(
"frameSeqId", event.frameSeqId)("layerTreeId", 1);

events.emplace_back(TraceEvent{
.name = "BeginFrame",
.cat = "devtools.timeline",
.ph = 'I',
.ts = event.start,
.pid = processId_,
.s = 't',
.tid = event.threadId,
.args = std::move(data),
});
},
[&](PerformanceTracerFrameCommitEvent&& event) {
folly::dynamic data = folly::dynamic::object(
"frameSeqId", event.frameSeqId)("layerTreeId", 1);

events.emplace_back(TraceEvent{
.name = "Commit",
.cat = "devtools.timeline",
.ph = 'I',
.ts = event.start,
.pid = processId_,
.s = 't',
.tid = event.threadId,
.args = std::move(data),
});
},
[&](PerformanceTracerFrameDrawEvent&& event) {
folly::dynamic data = folly::dynamic::object(
"frameSeqId", event.frameSeqId)("layerTreeId", 1);

events.emplace_back(TraceEvent{
.name = "DrawFrame",
.cat = "devtools.timeline",
.ph = 'I',
.ts = event.start,
.pid = processId_,
.s = 't',
.tid = event.threadId,
.args = std::move(data),
});
},
},
std::move(event));
}
Expand Down
35 changes: 34 additions & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,35 @@ class PerformanceTracer {
HighResTimeStamp createdAt = HighResTimeStamp::now();
};

struct PerformanceTracerSetLayerTreeIdEvent {
std::string frame;
int layerTreeId;
HighResTimeStamp start;
ThreadId threadId;
HighResTimeStamp createdAt = HighResTimeStamp::now();
};

struct PerformanceTracerFrameBeginDrawEvent {
int frameSeqId;
HighResTimeStamp start;
ThreadId threadId;
HighResTimeStamp createdAt = HighResTimeStamp::now();
};

struct PerformanceTracerFrameCommitEvent {
int frameSeqId;
HighResTimeStamp start;
ThreadId threadId;
HighResTimeStamp createdAt = HighResTimeStamp::now();
};

struct PerformanceTracerFrameDrawEvent {
int frameSeqId;
HighResTimeStamp start;
ThreadId threadId;
HighResTimeStamp createdAt = HighResTimeStamp::now();
};

using PerformanceTracerEvent = std::variant<
PerformanceTracerEventTimeStamp,
PerformanceTracerEventEventLoopTask,
Expand All @@ -276,7 +305,11 @@ class PerformanceTracer {
PerformanceTracerEventMeasure,
PerformanceTracerResourceSendRequest,
PerformanceTracerResourceReceiveResponse,
PerformanceTracerResourceFinish>;
PerformanceTracerResourceFinish,
PerformanceTracerSetLayerTreeIdEvent,
PerformanceTracerFrameBeginDrawEvent,
PerformanceTracerFrameCommitEvent,
PerformanceTracerFrameDrawEvent>;

#pragma mark - Private fields and methods

Expand Down
Loading