Add Performance Issues to Perf Monitor (1/2) #54265
Open
+314
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Introduces the concept of **Performance Issues**, an experimental performance signals concept for React Native. **Design** Performance Issues are an **experimental** user space API via the User Timings [`devtools` object](https://developer.chrome.com/docs/devtools/performance/extension#devtools_object). ``` performance.measure({ start, end, detail: { devtools: { ... rnIssueLevel: 'info' | 'warning' | 'error' } } }); ``` When `rnIssueLevel` is present, we eagerly report an the event over CDP, regardless of an active performance trace, via the `"__react_native_perf_issues_reporter"` runtime binding. **This diff** - Adds a `perfIssuesEnabled` feature flag. - Initial implementation of the above API. - Initially reports a "Cascading Render" issue, aligning 1:1 with the corresponding React performance track event (note: to be added in the React codebase, see facebook/react#34961). This feature is gated by the `perfMonitorV2Enabled` feature flag. Changelog: [Internal] Differential Revision: D85448200
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces the concept of Performance Issues, an experimental performance signals concept for React Native.
Design
Performance Issues are an experimental user space API via the User Timings
devtoolsobject.When
rnIssueLevelis present, we eagerly report an the event over CDP, regardless of an active performance trace, via the"__react_native_perf_issues_reporter"runtime binding.This diff
perfIssuesEnabledfeature flag.This feature is gated by the
perfMonitorV2Enabledfeature flag.Changelog: [Internal]
Differential Revision: D85448200