Add Performance Issues to Perf Monitor (2/2) #54266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
huntie
force-pushed
the
export-D85448199
branch
from
18e271a to
2f2132d
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Oct 27, 2025
Summary: Pull Request resolved: facebook#54266 Introduces the concept of **Performance Issues**, an experimental performance signals concept for React Native. **Design** Performance Issues are an **experimental** user space API via the User Timings [`devtools` object](https://developer.chrome.com/docs/devtools/performance/extension#devtools_object). ``` performance.measure({ start, end, detail: { devtools: { ... rnIssueLevel: 'info' | 'warning' | 'error' } } }); ``` When `rnIssueLevel` is present, we eagerly report an the event over CDP, regardless of an active performance trace, via the `"__react_native_perf_issues_reporter"` runtime binding. **This diff** - Updates the V2 Perf Monitor UI (Android) to display Performance Issues as a count. - (UI parts of this diff, including `HostTarget::installPerfIssuesBinding` are reinstated from the previous INP design, removed in D82208400). Changelog: [Internal] Differential Revision: D85448199
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Oct 28, 2025
Summary: Pull Request resolved: facebook#54266 Introduces the concept of **Performance Issues**, an experimental performance signals concept for React Native. **Design** Performance Issues are an **experimental** user space API via the User Timings [`devtools` object](https://developer.chrome.com/docs/devtools/performance/extension#devtools_object). ``` performance.measure({ start, end, detail: { devtools: { ... rnIssueLevel: 'info' | 'warning' | 'error' } } }); ``` When `rnIssueLevel` is present, we eagerly report an the event over CDP, regardless of an active performance trace, via the `"__react_native_perf_issues_reporter"` runtime binding. **This diff** - Updates the V2 Perf Monitor UI (Android) to display Performance Issues as a count. - (UI parts of this diff, including `HostTarget::installPerfIssuesBinding` are reinstated from the previous INP design, removed in D82208400). Changelog: [Internal] Differential Revision: D85448199
huntie
force-pushed
the
export-D85448199
branch
2 times, most recently
from
693c6c6 to
79656c7
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Oct 28, 2025
Summary: Pull Request resolved: facebook#54266 Introduces the concept of **Performance Issues**, an experimental performance signals concept for React Native. **Design** Performance Issues are an **experimental** user space API via the User Timings `detail` object. ``` performance.measure({ start, end, detail: { devtools: { ... }, rnPerfIssue: { name: 'React: Cascading Update', severity: 'warning', // 'info' | 'warning' | 'error', description: 'A cascading update is a update that is triggered by a previous update. This can lead to performance issues and should be avoided.', learnMoreUrl: 'https://react.dev/reference/dev-tools/react-performance-tracks#cascading-updates', } } }); ``` When `rnPerfIssue` is present, we eagerly report an the event over CDP, regardless of an active performance trace, via the `"__react_native_perf_issues_reporter"` runtime binding. **This diff** - Updates the V2 Perf Monitor UI (Android) to display Performance Issues as a count. - (UI parts of this diff, including `HostTarget::installPerfIssuesBinding` are reinstated from the previous INP design, removed in D82208400). Changelog: [Internal] Differential Revision: D85448199
…ate payload structure for Performance Issues (facebook#54265) Summary: Pull Request resolved: facebook#54265 Introduces the concept of **Performance Issues**, an experimental performance signals concept for React Native. **Design** Performance Issues are an **experimental** user space API via the User Timings `detail` object. ``` performance.measure({ start, end, detail: { devtools: { ... }, rnPerfIssue: { name: 'React: Cascading Update', severity: 'warning', // 'info' | 'warning' | 'error', description: 'A cascading update is a update that is triggered by a previous update. This can lead to performance issues and should be avoided.', learnMoreUrl: 'https://react.dev/reference/dev-tools/react-performance-tracks#cascading-updates', } } }); ``` When `rnPerfIssue` is present, we eagerly report an the event over CDP, regardless of an active performance trace, via the `"__react_native_perf_issues_reporter"` runtime binding. **This diff** - Adds a `perfIssuesEnabled` feature flag. - Initial implementation of the above API. - Initially reports a "Cascading Render" issue, aligning 1:1 with the corresponding React performance track event (note: to be added in the React codebase, see facebook/react#34961). This feature is gated by the `perfMonitorV2Enabled` feature flag. Changelog: [Internal] Differential Revision: D85448200
huntie
force-pushed
the
export-D85448199
branch
from
79656c7 to
3dee76d
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Oct 31, 2025
Summary: Pull Request resolved: facebook#54266 Introduces the concept of **Performance Issues**, an experimental performance signals concept for React Native. **Design** Performance Issues are an **experimental** user space API via the User Timings `detail` object. ``` performance.measure({ start, end, detail: { devtools: { ... }, rnPerfIssue: { name: 'React: Cascading Update', severity: 'warning', // 'info' | 'warning' | 'error', description: 'A cascading update is a update that is triggered by a previous update. This can lead to performance issues and should be avoided.', learnMoreUrl: 'https://react.dev/reference/dev-tools/react-performance-tracks#cascading-updates', } } }); ``` When `rnPerfIssue` is present, we eagerly report an the event over CDP, regardless of an active performance trace, via the `"__react_native_perf_issues_reporter"` runtime binding. **This diff** - Updates the V2 Perf Monitor UI (Android) to display Performance Issues as a count. - (UI parts of this diff, including `HostTarget::installPerfIssuesBinding` are reinstated from the previous INP design, removed in D82208400). Changelog: [Internal] Differential Revision: D85448199
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Oct 31, 2025
Summary: Pull Request resolved: facebook#54266 Introduces the concept of **Performance Issues**, an experimental performance signals concept for React Native. **Design** Performance Issues are an **experimental** user space API via the User Timings `detail` object. ``` performance.measure({ start, end, detail: { devtools: { ... }, rnPerfIssue: { name: 'React: Cascading Update', severity: 'warning', // 'info' | 'warning' | 'error', description: 'A cascading update is a update that is triggered by a previous update. This can lead to performance issues and should be avoided.', learnMoreUrl: 'https://react.dev/reference/dev-tools/react-performance-tracks#cascading-updates', } } }); ``` When `rnPerfIssue` is present, we eagerly report an the event over CDP, regardless of an active performance trace, via the `"__react_native_perf_issues_reporter"` runtime binding. **This diff** - Updates the V2 Perf Monitor UI (Android) to display Performance Issues as a count. - (UI parts of this diff, including `HostTarget::installPerfIssuesBinding` are reinstated from the previous INP design, removed in D82208400). Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D85448199
huntie
force-pushed
the
export-D85448199
branch
from
3dee76d to
b666f5b
Compare
Summary: Pull Request resolved: facebook#54266 Introduces the concept of **Performance Issues**, an experimental performance signals concept for React Native. **Design** Performance Issues are an **experimental** user space API via the User Timings `detail` object. ``` performance.measure({ start, end, detail: { devtools: { ... }, rnPerfIssue: { name: 'React: Cascading Update', severity: 'warning', // 'info' | 'warning' | 'error', description: 'A cascading update is a update that is triggered by a previous update. This can lead to performance issues and should be avoided.', learnMoreUrl: 'https://react.dev/reference/dev-tools/react-performance-tracks#cascading-updates', } } }); ``` When `rnPerfIssue` is present, we eagerly report an the event over CDP, regardless of an active performance trace, via the `"__react_native_perf_issues_reporter"` runtime binding. **This diff** - Updates the V2 Perf Monitor UI (Android) to display Performance Issues as a count. - (UI parts of this diff, including `HostTarget::installPerfIssuesBinding` are reinstated from the previous INP design, removed in D82208400). Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D85448199
huntie
force-pushed
the
export-D85448199
branch
from
b666f5b to
fc6b4fc
Compare
|
This pull request has been merged in a74387b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces the concept of Performance Issues, an experimental performance signals concept for React Native.
Design
Performance Issues are an experimental user space API via the User Timings
detailobject.When
rnPerfIssueis present, we eagerly report an the event over CDP, regardless of an active performance trace, via the"__react_native_perf_issues_reporter"runtime binding.This diff
HostTarget::installPerfIssuesBindingare reinstated from the previous INP design, removed in D82208400).Changelog: [Internal]
Differential Revision: D85448199