Skip to content

feat(iOS): add modal detents prop #54273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(iOS): add modal detents prop #54273

wants to merge 2 commits into from
+348 −83

Conversation

@okwasniewski
Copy link
Contributor

@okwasniewski okwasniewski commented Oct 25, 2025 •
edited
Loading

Summary:

This PR builds off the amazing work that @hurali97 did back in 2023. #34834

The previous PR didn't land because of significant delays when resizing the modal. Thanks to recent improvements we are now able to emit state updates synchronously thanks to EventQueue::UpdateMode::unstable_Immediate.

This PR builds off on that making the modal resizing buttery smooth.

modal.detents.mp4

Changelog:

[IOS] [ADDED] - implement modal detents prop

Test Plan:

  1. Open modal example
  2. Select use detents
  3. Play around with changing the values.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2025
@facebook-github-bot facebook-github-bot added p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 25, 2025
cipolleschi
cipolleschi approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this long wanted, awaited feature @okwasniewski!

@meta-codesync
Copy link

meta-codesync bot commented Oct 27, 2025

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D85554807.

@react-native-bot
Copy link
Collaborator

react-native-bot commented Oct 30, 2025 •
edited
Loading


Warnings
⚠️ ❗ JavaScript API change detected - This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API. Please include a clear changelog message. This change will be subject to extra review.

This change was flagged as: BREAKING

Generated by 🚫 dangerJS against f25ce97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@okwasniewski @react-native-bot @cipolleschi @facebook-github-bot