Update AbortController to more recent polyfill #54275
Conversation
The `abort-controller` package hasn't been updated since 2019, and is missing a number of useful features from the current DOM specification. So, switch to `abortcontroller-polyfill` to get a more modern implementation. Fixes facebook#42042 and facebook#50015.
|
Hi @wolfgang42! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
meta-cla
bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
Shared with Meta
|
Importing to run through internal CI, but this LGTM on the face of it, thanks @wolfgang42! |
|
@robhogan I can see that CI failed but no further details, LMK if there’s anything I can do to help. |
|
fyi, I found that |
4 participants
Summary:
The
abort-controllerpackage hasn't been updated since 2019, and is missing a number of useful features from the current DOM specification. So, switch toabortcontroller-polyfillto get a more modern implementation.Fixes #42042, fixes #50015.
Changelog:
[General] [Changed] - Improve AbortController API support
Test Plan:
I attempted to run
packages/react-native/src/private/webapis/dom/events/__tests__/EventTarget-itest.js, which exercises AbortController, but encountered problems getting fantom set up correctly; I am therefore relying on CI (and the assumption that the upstream package knows what they’re doing).