Skip to content

Comments

Fix indexed access in function arguments#55645

Open
j-piasecki wants to merge 13 commits intofacebook:mainfrom
j-piasecki:export-D93407605
Open

Fix indexed access in function arguments#55645
j-piasecki wants to merge 13 commits intofacebook:mainfrom
j-piasecki:export-D93407605

Conversation

@j-piasecki
Copy link
Contributor

Summary:
Changelog: [Internal]

Updates the C++ api snapshot generator to correctly handle arrays of fixed size.

Differential Revision: D93407605

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 20, 2026

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93407605.

Jakub Piasecki and others added 13 commits February 22, 2026 23:40
Summary: reserved

Differential Revision: D75793597
Differential Revision: D90959837
Summary:
Pull Request resolved: facebook#55641

Changelog: [Internal]

Adds basic implementation of C++ API snapshot generation and snapshot tests covering the functionality.

Differential Revision: D90987176
Differential Revision: D94073960
Differential Revision: D94073981
Differential Revision: D94074032
Differential Revision: D94074045
Differential Revision: D94074054
Summary:
Refactors utils.py into a proper package structure and adds comprehensive argument string parsing utilities.

- Converts utils.py to utils/ package with submodules
- Adds argument_parsing.py with parse_arg_string() and related utilities
- Adds qualified_path.py with parse_qualified_path moved from old utils.py
- Renames test_member.py to test_parse_arg_string.py with updated tests for the new 4-tuple Argument format
- Minor cosmetic improvement to doxygen output messages

Differential Revision: D94077819
Summary:
Implements fallback name qualification for cases where doxygen doesn't extract the full qualified name, and instead passes on the string it found in the header file.

- Adds type_qualification.py with qualify_type_str(), qualify_arguments(), and qualify_parsed_type()
- Updates member.py with close() methods for VariableMember, FunctionMember, and TypedefMember to apply type qualification
- Updates main.py with get_doxygen_params() to extract structured parameter info
- Fixes scope.py qualify_name() to properly track anchor_scope for partially-qualified names
- Adds comprehensive test cases for various qualification scenarios

Differential Revision: D94077825
Differential Revision: D93407597
Summary:
Pull Request resolved: facebook#55645

Changelog: [Internal]

Updates the C++ api snapshot generator to correctly handle arrays of fixed size.

Reviewed By: cipolleschi

Differential Revision: D93407605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants