build(cudf): Bring in ucxx when ucx is present and update all RAPIDS dependencies to latest#17572
build(cudf): Bring in ucxx when ucx is present and update all RAPIDS dependencies to latest#17572zoltan wants to merge 6 commits into
Conversation
When VELOX_ENABLE_CUDF is on and system UCX (libucp + headers) is detected, declare and fetch ucxx alongside the other rapids dependencies. Nothing links against ucxx yet upstream; the wiring prepares the ground for a future ucx-exchange consumer. Also bumps the default UCX version in setup-centos-adapters.sh from 1.19.0 to 1.20.1 (with matching docstring) to align with the version shipped in our dependency images. ucxx is pinned to commit 8d47a9f (release v0.49.00) and uses the same commit-archive URL pattern as the other rapids deps so the update-cudf-deps.sh tooling can be extended uniformly.
✅ Deploy Preview for meta-velox canceled.
|
|
@bdice as discussed, this brings in ucxx as a dependency FYI @dan13bauer |
Build Impact AnalysisNo build targets affected by this change. Slow path • Graph generated from PR branch |
There was a problem hiding this comment.
I recommend adopting UCX_FOUND before merging.
I also filed zoltan#1 which includes ucxx in the cuDF dependency update script and bumps to the latest commits from release/26.06. Feel free to include one or both of those commits in this PR if you like, or we can do that in a followup.
|
thank you. let me incorporate everything and update the PR. |
|
@zoltan Would it also make sense to update |
Adopt the conventional <LIB>_FOUND pattern per review feedback: derive a single UCX_FOUND boolean from the find_library/find_path probe and test it at all three gate sites instead of repeating `UCX_LIBRARY AND UCX_INCLUDE_DIR`. Pure refactor, no behavior change. Also correct the stale ucxx pin comment: commit 2e37c84 is the tip of the release/0.50 branch (VERSION 0.50.00), not a tagged v0.49.00/v0.50.00 release, so annotate it as the branch rather than claiming a release tag.
|
@bdice no problem with the push. thanks for the scripts! @dan13bauer as we have discussed today I think it's better to have a separate PR for that to spark a discussion how we can fix it on the CI so we don't need to exclude it in the future. |
|
@zoltan , @bdice the build is failing. Can you look? |
|
we're failing because #17712 is not merged in yet. once it's in, I'll rebase. |
|
@zoltan We need to land #17704 (which also has some cuDF version updates needed to fix a bug) and #17712, then I will fix up the versions pinned in this PR. We have to pin to cuDF (and dependencies) from 26.06 until we support CMake 4.0 (#17637), but that shouldn't be a blocker for this PR -- we can pin to 26.06 for now rather than going to 26.08. This is on my radar and I'll help fix it up once we get the other CI blockers resolved. |
When VELOX_ENABLE_CUDF is on and system UCX (libucp + headers) is detected, declare and fetch ucxx alongside the other rapids dependencies. Nothing links against ucxx yet upstream; the wiring prepares the ground for a future ucx-exchange consumer.
Also bumps the default UCX version in setup-centos-adapters.sh from 1.19.0 to 1.20.1 (with matching docstring) to align with the version shipped in our dependency images.
ucxx is pinned to commit 8d47a9f (release v0.49.00) and uses the same commit-archive URL pattern as the other rapids deps so the update-cudf-deps.sh tooling can be extended uniformly.