Add Spark cast mode special form registration#17687
Open
ReemaAlzaid wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for meta-velox canceled.
|
Build Impact AnalysisSelective Build Targets (building these covers all 21 affected)Total affected: 21/580 targets Affected targets (21)Directly changed (2)
Transitively affected (19)
Fast path • Graph from main@70256ffc69a3077c68079822d3d2b37f0c88cf8c |
rui-mo
reviewed
Jun 4, 2026
Collaborator
rui-mo
left a comment
There was a problem hiding this comment.
Please add tests and update relevant documentations. Thanks.
Also FYI: https://github.com/facebookincubator/velox/blob/main/scripts/review/SELF_REVIEW.md
| const core::QueryConfig& config) override; | ||
| }; | ||
|
|
||
| void registerSparkCastModeSpecialForms( |
Collaborator
There was a problem hiding this comment.
Currently no call site wires it into registration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SparkCastExprwith the correct try-cast and overflow behavior.isAnsiSupportedso ANSI cast handling can fall back for unsupported cast pairs.related PR: apache/gluten#12051