fix: Bump folly tag to v2026.02.16.00#17695
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
sungwoo-XCENA
changed the title
Build Impact AnalysisNo build targets affected by this change. Slow path • Graph generated from PR branch |
The tag bump left VELOX_FOLLY_BUILD_SHA256_CHECKSUM at the v2026.01.05.00 hash, so the bundled-dependencies build failed folly download verification with a hash mismatch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
v2026.02.16.00 carries folly's IoUringOptions.h, but fizz at that tag links a mis-named benchmark target (Folly::folly_benchmark, while folly exports follybenchmark), breaking the fizz build. fizz fixes this at v2026.06.01.00 -- the earliest FBOS tag where folly and fizz agree on the benchmark target and folly still provides IoUringOptions.h. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Bumped folly version to v2026.06.01.00 because fizz's v2026.02.16.00 version had a mismatch problem with folly, which was fixed at v2026.06.01.00. That was the common denominator between this issue and fizz issue. |
|
As FYI this not only updates folly but the entire stack of the FBOS dependencies. This might introduce other problems. You also need to update https://github.com/facebookincubator/velox/blob/main/CMake/resolve_dependency_modules/README.md |
2 participants
This fixes #17694.
In summary,
AsyncIoContext.cppconditionally included<folly/io/async/IoUringOptions.h>, which does not exist in the current pinned folly version. This fix bumps the folly version to v2026.02.16.00.