docs(review): Consolidate PR review guidance across skill and guides#17696
Open
kKPulla wants to merge 1 commit into
Open
docs(review): Consolidate PR review guidance across skill and guides#17696kKPulla wants to merge 1 commit into
kKPulla wants to merge 1 commit into
Conversation
The `/pr-review` skill and `scripts/review/REVIEW_GUIDE.md` previously carried overlapping and occasionally contradictory guidance — different output formats, different fetch instructions, different sets of principles. A reviewer using the skill on a function PR also missed `FUNCTION_PR_GUIDE.md` entirely because the skill never referenced it. Make the skill the single point of entry: it orchestrates the review and loads the human-readable guides for content, so AI and human reviews stay consistent. The skill is now a staged pipeline: detect mode, fetch, load content, analyze, draft, approve, post. Substantive review content (rigor, tone, what to check) moves out of the skill; the skill now points to `REVIEW_GUIDE.md` as the source of truth. `FUNCTION_PR_GUIDE.md` loads automatically when the diff touches `velox/functions/`, with a subtree guard so the function checklist doesn't apply to tests/benchmarks/fuzzer-only PRs. Three net-new principles fold into `REVIEW_GUIDE.md`: assume competence, permission to be quiet, focus on what CI cannot check. Local-mode drafts move from `/tmp/` to `~/.claude/review-drafts/pr-NNNNN-rN-vN.md` to match `REVIEW_GUIDE.md`'s existing procedure. The skill creates the directory on first use. `rN` is the re-review round; `vN` is the iteration within a round.
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
pratikpugalia
approved these changes
Jun 3, 2026
Contributor
|
I meant to streamline this too. Looks neat! Thanks @kKPulla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/pr-reviewskill the single orchestrator for PR reviews, loading human-readable guides (REVIEW_GUIDE.md,FUNCTION_PR_GUIDE.md) as content rather than duplicating them.REVIEW_GUIDE.md(assume competence, permission to be quiet, focus on what CI cannot check) and move local-mode drafts from/tmp/to~/.claude/review-drafts/.Test plan
/pr-review https://github.com/facebookincubator/velox/pull/17665) — fetched viafetch.py, loadedCODING_STYLE.md+REVIEW_GUIDE.md, drafted to~/.claude/review-drafts/pr-17665-r1-v1.md.