Skip to content

fbcode/velox/functions/prestosql/aggregates/MapAccumulator.h #17700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meta-codesync wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fbcode/velox/functions/prestosql/aggregates/MapAccumulator.h #17700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions velox/functions/prestosql/aggregates/MapAccumulator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#pragma once

#include <folly/container/F14Map.h>
#include <folly/container/Reserve.h>
#include "velox/common/memory/HashStringAllocator.h"
#include "velox/exec/AddressableNonNullValueList.h"
#include "velox/exec/Strings.h"
Expand Down Expand Up @@ -66,6 +67,10 @@ struct MapAccumulator {
}
}

void reserveAdditional(size_t n) {
folly::grow_capacity_by(keys, n);
}

/// Returns number of key-value pairs.
size_t size() const {
return keys.size();
Expand Down Expand Up @@ -140,6 +145,10 @@ struct StringViewMapAccumulator {
}
}

void reserveAdditional(size_t n) {
base.reserveAdditional(n);
}

size_t size() const {
return base.size();
}
Expand Down Expand Up @@ -191,6 +200,10 @@ struct ComplexTypeMapAccumulator {
base.values.appendValue(decodedValues, index, &allocator);
}

void reserveAdditional(size_t n) {
base.reserveAdditional(n);
}

size_t size() const {
return base.size();
}
Expand Down Expand Up @@ -303,6 +316,10 @@ struct CustomComparisonMapAccumulator {
return base.insert(decodedKeys, decodedValues, index, allocator);
}

void reserveAdditional(size_t n) {
base.reserveAdditional(n);
}

/// Returns number of key-value pairs.
size_t size() const {
return base.size();
Expand Down
2 changes: 2 additions & 0 deletions velox/functions/prestosql/aggregates/MapAggregateBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ class MapAggregateBase : public exec::Aggregate {
auto size = mapVector->sizeAt(decodedRow);
auto tracker = trackRowSize(group);
checkNullKeys(decodedKeys_, offset, size);
accumulator->reserveAdditional(size);
for (auto i = offset; i < offset + size; ++i) {
accumulator->insert(decodedKeys_, decodedValues_, i, *allocator_);
}
Expand Down Expand Up @@ -178,6 +179,7 @@ class MapAggregateBase : public exec::Aggregate {
auto offset = mapVector->offsetAt(decodedRow);
auto size = mapVector->sizeAt(decodedRow);
checkNullKeys(decodedKeys_, offset, size);
accumulator->reserveAdditional(size);
for (auto i = offset; i < offset + size; ++i) {
accumulator->insert(decodedKeys_, decodedValues_, i, *allocator_);
}
Expand Down
Loading