Skip to content

fix: Skip the fuzzer test for Spark regexp_instr function#17709

Closed
rui-mo wants to merge 1 commit into
facebookincubator:mainfrom
rui-mo:wip_skip
Closed

fix: Skip the fuzzer test for Spark regexp_instr function#17709
rui-mo wants to merge 1 commit into
facebookincubator:mainfrom
rui-mo:wip_skip

Conversation

@rui-mo
Copy link
Copy Markdown
Collaborator

@rui-mo rui-mo commented Jun 3, 2026

The regex cache limit makes expression evaluation order-dependent. Common eval
and simplified eval process rows in different orders, so they hit the cache
limit on different rows, producing different results. This PR skips the uzzer
test for Spark regexp_instr function.

Fixes #17697.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 3, 2026

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit dd6d389
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/6a1f93d40aaac60009006d7e

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Build Impact Analysis

Selective Build Targets (building these covers all 1 affected)

cmake --build _build/release --target spark_expression_fuzzer_test

Total affected: 1/580 targets

Affected targets (1)

Directly changed (1)

Target Changed Files
spark_expression_fuzzer_test SparkExpressionFuzzerTest.cpp

Fast path • Graph from main@ef557e4da679bd1bfe7ed48c9241bdfed41d35fc

@rui-mo
Copy link
Copy Markdown
Collaborator Author

rui-mo commented Jun 4, 2026

Thanks @zhli1142015. Could you please mark ready-to-merge label for this PR? Thank you.

@zhli1142015
Copy link
Copy Markdown
Contributor

It looks like I lost my Collaborator permissions for some reason, though I'm not sure why. You can tag the ready-to-merge label yourself to unblock for now.

@pedroerp , could you help restore my Collaborator access? Thanks!

@rui-mo
Copy link
Copy Markdown
Collaborator Author

rui-mo commented Jun 4, 2026

@zhli1142015 Thanks. Yes, the permissions may need to be restored.

@rui-mo rui-mo added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jun 4, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Jun 4, 2026

@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this in D107540998.

@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Jun 4, 2026

@bikramSingh91 merged this pull request in 9092f52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spark expression fuzzer mismatch: common and simplified eval hit regexp_instr regex cache limit on different rows

2 participants