build: Exclude ucx-exchange sources from clang-tidy#17715
Closed
dan13bauer wants to merge 1 commit into
Closed
Conversation
clang-tidy does not support CUDA compiler flags or CUDA/UCX headers, so the ucx-exchange GPU transport sources cannot be compiled as standalone translation units. Exclude them from both the changed-line detection and the file list, mirroring the existing cudf/ and wave/ exclusions.
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
Collaborator
Author
|
@majetideepak Is there a way to make clang support the CUDA/UCX headers? FYI: @zoltan |
bikramSingh91
approved these changes
Jun 4, 2026
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this in D107459896. |
bikramSingh91
added
the
ready-to-merge
|
@bikramSingh91 merged this pull request in 058b1a3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exclude
ucx-exchange/sources fromscripts/checks/run-clang-tidy.py, mirroringthe existing
cudf/andwave/exclusions.Motivation
The
ucx-exchangeGPU transport plugin (undervelox/experimental/) is built ontop of cuDF and UCX. Its sources pull in CUDA compiler flags and CUDA/UCX headers,
which clang-tidy does not support — the same reason
cudf/andwave/are alreadyexcluded. Without this exclusion, clang-tidy fails when it encounters changed
ucx-exchange/files.Changes
"ucx-exchange/" not in matched_fileto the changed-line detection ingit_changed_lines, so changed lines in those files are not collected fortidying.
"ucx-exchange/" not in fileto the file-list filter intidy, so thosefiles are excluded from the clang-tidy run.