change WPS' HTA parsing backend to illustrate potential differences#168
Open
jj10306 wants to merge 1 commit intofacebookresearch:mainfrom
Open
change WPS' HTA parsing backend to illustrate potential differences#168jj10306 wants to merge 1 commit intofacebookresearch:mainfrom
jj10306 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: - update `ijson` parsing backend of HTA to handle `ns` timestamps in the same way as the `json` backend - after this, the `ijson` and `json` backends give the same results when running the WPS test mentioned below - the above HTA changes the expected values of the WPS test slightly since the number of trace events changed slightly due to the fix in incorrectly overlapping events Differential Revision: D59860746
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59860746 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ijsonparsing backend of HTA to handlenstimestamps in the same way as thejsonbackendijsonandjsonbackends give the same results when running the WPS test mentioned belowDifferential Revision: D59860746