Update ijson trace metadata parsing to include fields after "traceEvents"#226
Open
jj10306 wants to merge 1 commit intofacebookresearch:mainfrom
Open
Update ijson trace metadata parsing to include fields after "traceEvents"#226jj10306 wants to merge 1 commit intofacebookresearch:mainfrom
jj10306 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70114793 |
…nts" (facebookresearch#226) Summary: The ijson-based metadata parsing had an early exit when the "traceEvents" key was encountered. This led to metadata fields after "traceEvents" to be excluded from the trace's metadata object. Also remove unnecessary print in `trace_event_timestamp_to_unixtime_ns` Differential Revision: D70114793
jj10306
force-pushed
the
export-D70114793
branch
from
e42ba8a to
7d72e97
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70114793 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The ijson-based metadata parsing had an early exit when the "traceEvents" key was encountered. This led to metadata fields after "traceEvents" to be excluded from the trace's metadata object.
Also remove unnecessary print in
trace_event_timestamp_to_unixtime_nsDifferential Revision: D70114793