Add HIP/ROCm support to cuda_kernel_launch_stats#321
Add HIP/ROCm support to cuda_kernel_launch_stats#3211274085042 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Add support for HIP runtime events (hipLaunchKernel, hipLaunchKernelExC, hipMemcpyAsync, hipMemsetAsync) in cuda_kernel_launch_stats method, enabling kernel launch statistics analysis for ROCm/HIP traces. Changes: - Add HIP symbol lookups alongside existing CUDA symbols - Include hipLaunchKernel/hipLaunchKernelExC in launch_ids - Include hipMemcpyAsync/hipMemsetAsync in memory event filtering - Use isin() for memory event filtering (cleaner, handles None safely) - Add comprehensive unit tests (9 test cases) covering: - HIP launch kernel events - HIP memory events (include/exclude) - Mixed CUDA+HIP traces - Pure ROCm traces (no CUDA symbols) - Negative launch delay clipping - Multiple ranks - Empty trace handling"'
|
Hi @1274085042! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
CLA has been signed. This PR adds HIP/ROCm support to |
|
Hi @fengxizhou @sanrise, could you please review this PR when you have a chance? It adds HIP/ROCm support to cuda_kernel_launch_stats, enabling kernel launch statistics analysis for ROCm/HIP traces. |
|
Hi @albanD , could you please review this PR when you have a chance? It adds HIP/ROCm support to cuda_kernel_launch_stats, enabling kernel launch statistics analysis for ROCm/HIP traces. |
|
I don't think I have review rights on this repo. |
Add support for HIP runtime events (hipLaunchKernel, hipLaunchKernelExC, hipMemcpyAsync, hipMemsetAsync) in cuda_kernel_launch_stats method, enabling kernel launch statistics analysis for ROCm/HIP traces.
Changes: