-
Notifications
You must be signed in to change notification settings - Fork 402
Formation energy calculator #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@lbluque: Thanks for putting this together! Do you have an ETA for when this PR might be merged? We are hoping to submit a manuscript next month where we think the results of this PR could significantly improve our results and would be interested in trying it out before we send off the paper. I was meeting with @zulissi today and he suggested I reach out. |
|
Hi @Andrew-S-Rosen 👋 This is mainly just pending getting the DFT calculations ready and uploaded to HF. I'll see if I can push on this to have it ready by next week! |
|
@lbluque: That would be great, thanks! We'll be sure to include the results in our paper then and be the first to use it! Tagging @aryannsaha. This is what I will have you try once it's merged. |
zulissimeta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relatively minor comments here. The major question in my mind is whether using set_predict_formation_energy to modify a calculator is the right approach here.
| pprint.pprint(f"Total energy: {result["results"]["energy"] eV\n Formation energy {form_energy} eV}) | ||
| ``` | ||
|
|
||
| Congratulations; you ran your first relaxation and predicted the formation energy of MgO using UMA and `quacc`! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a numerical comparison to the MP value here? Just mention what MP says and include a link to the MP structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
==========================================
- Coverage 66.49% 65.86% -0.64%
==========================================
Files 131 131
Lines 10781 10607 -174
==========================================
- Hits 7169 6986 -183
- Misses 3612 3621 +9 ☔ View full report in Codecov by Sentry. |
Implement automatic formation energy predictions.
calculatemethod. This way I did not touch any of the calculator code and its usage is explicit and descriptive to users.fairchem.data.omatto be installed.Usage:
Tests need #1603 to pass