fix: initializing order of gpu compile options #4581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pankajsingh88 has imported this pull request. If you are a Meta employee, you can view this in D82647834. |
|
Hi @simshi , thanks for the contribution; what was the error and how did you repro? |
The result is get_compile_options() returns without "GPU". No guarantee to reproduce, my dev environment is ubuntu18 with gcc 8.4.0 |
|
@mnorris11 has imported this pull request. If you are a Meta employee, you can view this in D82647834. |
|
@pankajsingh88 merged this pull request in 97dc014. |
AlSchlo
pushed a commit
to AlSchlo/faiss-panorama
that referenced
this pull request
Oct 20, 2025
Summary: # issue I met gpu_compile_options initialization order issue over gcc 8.4.0. Maybe related with LTO bug? # solution make it deterministic, no "crossing fingers" required. 😸 Pull Request resolved: facebookresearch#4581 Reviewed By: subhadeepkaran Differential Revision: D82647834 Pulled By: pankajsingh88 fbshipit-source-id: ead9515dc6e84987e6c8f5471318a34cc5b81086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
I met gpu_compile_options initialization order issue over gcc 8.4.0. Maybe related with LTO bug?
solution
make it deterministic, no "crossing fingers" required. 😸