Sampling with likelihoods #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhavasi
requested changes
Aug 20, 2025
timonpalm
force-pushed
the
sample_w_likelihood
branch
from
1172ef7 to
0e04528
Compare
timonpalm
commented
Aug 20, 2025
| torch.allclose(forward_log_likelihood, backward_log_likelihood, atol=1e-2), | ||
| ) | ||
|
|
||
| def test_forward_backward_likelihoods(self): |
There was a problem hiding this comment.
Hey, thanks for the PR. Can you also add a test that compares the output of the forward compute_likelihood and the backward compute_likelihood to make sure they match?
Is this sufficient? It computes the forward likelihood, while generating samples. Then using those samples to compute the backward likelihood and compare them.
The odesolver.compute_likelihood does not allow a forward computation, as it also would't make sense without x1 samples?!
Maybe I am misunderstanding sth. here ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #62
I expanded the
ODESolver.sample()method to compute likelihoods along the way when sampling, alleviating the two step integration.You just have to pass the
log_p0parameter to the function.