Fix mypy and ufmt CI failures in sprio module - #50
Merged
Conversation
- Use @overload for sprio_parsed_field to fix incompatible default type (type[str] vs Callable[[str], T]) - Change raw_data annotation to dict[Hashable, Any] to match Mapping[Hashable, Any] expected by instantiate_dataclass and Mapping[Hashable, str | int] expected by get_derived_cluster - Use dict[str, Any] in test to fix **dict unpacking type errors - Fix import ordering (ufmt format)
Some versions of GNU date -f skip invalid lines and exit 0 instead of failing. Check stderr for error output to detect these cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sprio_parsed_fieldtype signature using@overloadto resolve mypy error with incompatible default (type[str]vsCallable[[str], T])raw_dataannotation incli/sprio.pyfromdict[str, str]todict[Hashable, Any]to satisfyinstantiate_dataclassandget_derived_clustertype signatures (matching the pattern used inclient.py)dict[str, Any]intest_sprio.pyto fix**dictunpacking type errors withSprioRowTest plan
mypy gcmpasses (0 errors across 232 files)ufmt check gcmpasses (all files formatted)flake8 gcmpassespytest gcm/tests/test_sprio.pypasses