Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] MMFT MLP head output key; mix model losses and MMFLosses #925

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apsdehal
Copy link
Contributor

@apsdehal apsdehal commented May 4, 2021

This will allow doing multitasking on single batch easily through
different heads with different output_key per task

Mixing allows usage of heads that returns losses directly with heads
that don't and rely on MMFLoss

Test Plan:
Tests have been added

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 4, 2021
@facebook-github-bot
Copy link
Contributor

@apsdehal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This will allow doing multitasking on single batch easily through
different heads with different output_key per task

Mixing allows usage of heads that returns losses directly with heads
that don't and rely on MMFLoss

Test Plan:
Tests have been added
@apsdehal apsdehal force-pushed the mmft_output_key branch from dd901de to 9b34e1f Compare May 4, 2021 21:18
@facebook-github-bot
Copy link
Contributor

@apsdehal has updated the pull request. You must reimport the pull request before landing.

@apsdehal apsdehal changed the title [feat] Allow specifying output_key for mlp head in MMFT [feat] MMFT MLP head output key; mix model losses and MMFLosses May 4, 2021
@facebook-github-bot
Copy link
Contributor

@apsdehal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants