Skip to content

Conversation

@moto-meta
Copy link
Contributor

@moto-meta moto-meta commented Sep 19, 2025

Summary:
Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte strings are created by read method,
and they must be returned from C++ to Python.

Differential Revision: D82753127

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 19, 2025
@facebook-github-bot
Copy link
Contributor

@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82753127.

facebook-github-bot pushed a commit that referenced this pull request Sep 19, 2025
Summary:

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
@facebook-github-bot
Copy link
Contributor

@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82753127.

facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2025
Summary:

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
@facebook-github-bot
Copy link
Contributor

@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82753127.

facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2025
Summary:

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
@facebook-github-bot
Copy link
Contributor

@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82753127.

facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2025
Summary:

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
@facebook-github-bot
Copy link
Contributor

@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82753127.

facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2025
Summary:

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
@facebook-github-bot
Copy link
Contributor

@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82753127.

facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2025
Summary:

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
@facebook-github-bot
Copy link
Contributor

@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82753127.

facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2025
Summary:

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
@facebook-github-bot
Copy link
Contributor

@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82753127.

facebook-github-bot pushed a commit that referenced this pull request Oct 14, 2025
Summary:

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
@meta-codesync
Copy link

meta-codesync bot commented Oct 14, 2025

@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82753127.

facebook-github-bot pushed a commit that referenced this pull request Oct 14, 2025
Summary:

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
facebook-github-bot pushed a commit that referenced this pull request Oct 14, 2025
Summary:

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
moto-meta pushed a commit that referenced this pull request Oct 14, 2025
Summary:
Pull Request resolved: #958

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
moto-meta pushed a commit that referenced this pull request Oct 14, 2025
Summary:
Pull Request resolved: #958

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
@mthrok mthrok changed the title WIP: TarIterator Add spdl.io.ite_tarfile function Oct 14, 2025
@mthrok mthrok changed the title Add spdl.io.ite_tarfile function Add spdl.io.iter_tarfile function Oct 14, 2025
moto-meta pushed a commit that referenced this pull request Oct 14, 2025
Summary:
Pull Request resolved: #958

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
Summary:
Pull Request resolved: #958

Add basic implementation for iterating in-memory TAR data and file-like object.

It is tricky to workaround the GIL in file-like object as the byte string created by `read` method must be returned from C++ to Python.

Differential Revision: D82753127
@meta-codesync meta-codesync bot merged commit b631f13 into main Oct 14, 2025
84 of 91 checks passed
@mthrok mthrok deleted the export-D82753127 branch October 14, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants