Add sCAM - #486
Merged
Merged
Conversation
gir-bot
added
S: needs-review
facelessuser
force-pushed
the
feature/scam
branch
2 times, most recently
from
August 23, 2025 16:35
00bead4 to
190e545
Compare
facelessuser
force-pushed
the
feature/scam
branch
2 times, most recently
from
August 28, 2025 18:33
ae2320e to
d7f4b26
Compare
facelessuser
force-pushed
the
feature/scam
branch
from
September 8, 2025 15:28
d7f4b26 to
7b10658
Compare
facelessuser
force-pushed
the
feature/scam
branch
from
September 16, 2025 15:56
7b10658 to
4e6f433
Compare
facelessuser
force-pushed
the
feature/scam
branch
3 times, most recently
from
December 4, 2025 05:04
5f6cd4c to
3304307
Compare
facelessuser
force-pushed
the
feature/scam
branch
4 times, most recently
from
January 16, 2026 04:44
2450ad7 to
8ae663d
Compare
Owner
Author
|
All we need now is tests |
There were two contradictory values used in the sCAM paper. We used the one that matched colour science, but now there was a correction that clarifies that `0.1`, not `0.46`, is correct.
facelessuser
force-pushed
the
feature/scam
branch
from
January 16, 2026 17:30
038b61f to
4934909
Compare
- Use proper constants - Reduce duplicate code
facelessuser
force-pushed
the
feature/scam
branch
from
January 16, 2026 21:47
8f8d01b to
28abeba
Compare
facelessuser
marked this pull request as ready for review
January 17, 2026 00:32
Owner
Author
|
@gir-bot lgtm |
gir-bot
added
S: approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #485