Skip to content

warn missing x_scatter in read simulated spectrum instead of exception #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

warn missing x_scatter in read simulated spectrum instead of exception #127

wants to merge 1 commit into from

Conversation

jebuss
Copy link
Member

@jebuss jebuss commented Jun 14, 2019

warn missing x_scatter in read simulated spectrum instead of raising an exception. This is needed for old MMCs corsikas who do not have this attribute

@jebuss
warn missing x_scatter in read simulated spectrum instead of raising …
2348eb4 
…an exception. This is needed for old MMCs corsikas who do not have this attribute
@jebuss jebuss requested a review from maxnoe June 14, 2019 09:58
maxnoe
maxnoe reviewed Jun 14, 2019
View reviewed changes
Copy link
Member

@maxnoe maxnoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the idea was that the new files contain a column with the info and for the old files we just add the attribute.

As this information is needed, I think raising an error is better when it's not there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxnoe maxnoe maxnoe left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jebuss @maxnoe