#27: no empty item descriptions

[bbqbaron]

Hi! This app is a great idea. I picked what looked like a really simple issue to try contributing.

• throw a generic exception if item description is empty
• add test
• update tests that were using empty item descriptions

Is simply throwing some message what you had in mind? Am I missing any more complicated way of validating inputs?

[facundoolano]

Hi! thanks for contributing!

Actually this issue targeted a more specific thing (I know the title doesn't say much, it's a quick transcript from some notes I had).

There was a bug where the game would crash on runtime if one of the item descriptions was an empty string "" (this is what I recall, unfortunately it was a while ago).

I wouldn't add this isolated validation, I think input validation should be tackled in a more general way (that's what #46 is about). For this particular issue it would be enough with reproducing the error and preventing it to crash (for example using the default description if the string is clojure.string/blank?).

[bbqbaron]

Oh! Good news then; I think it may be fixed. I can reproduce it in advenjure-example, but I think it was caused by calling capfirst in utils/say, and calling clojure.string/capitalize (first s) unconditionally in capfirst, neither of which happens anymore AFAICT?

[facundoolano]

Yeah that makes sense, I saw it on the house taken over have, which used an older version. I'll close this and the issue, we can reopen if we see it again.

Thanks for looking into it.