-
Notifications
You must be signed in to change notification settings - Fork 122
email body as text area #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.x-3.x
Are you sure you want to change the base?
Changes from all commits
ce53b04
114b3e1
fe1a30e
8e3f1a7
230d103
3ea66cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,6 +60,25 @@ public function getAssignmentRestriction(); | |
*/ | ||
public function setAssignmentRestriction($restriction); | ||
|
||
/** | ||
* Determines form element for the context type | ||
* e.g textarea. | ||
* | ||
* @return string | ||
* Type of form element to be used. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. return type is wrong, this should be "string", right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add an example, '... , for example "textarea".' |
||
*/ | ||
public function getFormElement(); | ||
|
||
/** | ||
* Sets the form element for context. | ||
* | ||
* @param string $form_element | ||
* Type of form element to be used. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add an example, '... , for example "textarea"."' |
||
* | ||
* @return $this | ||
*/ | ||
public function setFormElement($form_element); | ||
|
||
/** | ||
* Exports the definition as an array. | ||
* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You haven't added 'formElement'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'formElement' is at src/Plugin/RulesAction/SystemSendEmail.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I can see. You need something like:
ContextDefinition::toArray() is trying to set ContextDefinition::$formElement and it doesn't exist yet.