Skip to content

refactor(LoginPage): Remove mounted call for test login method - #208

Open
qux-bbb wants to merge 1 commit into
falcosecurity:masterfrom
qux-bbb:patch-1
Open

refactor(LoginPage): Remove mounted call for test login method#208
qux-bbb wants to merge 1 commit into
falcosecurity:masterfrom
qux-bbb:patch-1

Conversation

@qux-bbb

@qux-bbb qux-bbb commented Mar 29, 2026

Copy link
Copy Markdown

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area tests

What this PR does / why we need it:
This PR refactors the LoginPage component by removing the mounted lifecycle hook call that was used for testing the login method.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: qux-bbb <1147635419@qq.com>
@poiana

poiana commented Mar 29, 2026

Copy link
Copy Markdown

Welcome @qux-bbb! It looks like this is your first PR to falcosecurity/falcosidekick-ui 🎉

@poiana poiana added the size/XS label Mar 29, 2026
@poiana
poiana requested review from Issif and cpanato March 29, 2026 05:06
@poiana

poiana commented Mar 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qux-bbb
Once this PR has been reviewed and has the lgtm label, please assign issif for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana

poiana commented Jun 27, 2026

Copy link
Copy Markdown

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana

poiana commented Jul 27, 2026

Copy link
Copy Markdown

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants