Skip to content

Fix typos in signer-requests.md and signers.md #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/hubble/migrating.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Read APIs are fully backwards compatible with hubs so no migration is required.
Via http once you have a node running

```bash
curl http://locaalhost:3381/v1/info
curl http://localhost:3381/v1/info
```

Via grpc
Expand All @@ -36,7 +36,7 @@ If you are using Shuttle, it will work the same as before. Just need to point it

The write APIs are also backwards compatible with hubs, with some caveats (see below).

In order to write to snapchain, you should run a node and submit directly to it. Refer to [existing docs](https://docs.farcaster.xyz/developers/guides/writing/submit-messages) for writing dia via the client library. Note, you **MUST** use version `0.16` or later of the `hub-nodejs` library.
In order to write to snapchain, you should run a node and submit directly to it. Refer to [existing docs](https://docs.farcaster.xyz/developers/guides/writing/submit-messages) for writing data via the client library. Note, you **MUST** use version `0.16` or later of the `hub-nodejs` library.

### Gotchas

Expand All @@ -62,4 +62,4 @@ wget https://raw.githubusercontent.com/farcasterxyz/snapchain/refs/heads/main/do
docker compose up # -d to run in the background
```

Note, testnet is unstable and will be reset from time to time.
Note, testnet is unstable and will be reset from time to time.
4 changes: 2 additions & 2 deletions docs/reference/warpcast/signer-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const key = '0x' + Buffer.from(publicKeyBytes).toString('hex');
/*** Generating a Signed Key Request signature ***/

const appFid = process.env.APP_FID;
const account = mnemonicToAccount(process.env.APP_MNENOMIC);
const account = mnemonicToAccount(process.env.APP_MNEMONIC);

const deadline = Math.floor(Date.now() / 1000) + 86400; // signature is valid for 1 day
const signature = await account.signTypedData({
Expand Down Expand Up @@ -180,7 +180,7 @@ poll(token);

When the user approves the request in Warpcast, an onchain transaction will be
made that grants write permissions to that signer. Once that completes your app
should indicate success and can being writing messages using the newly added key.
should indicate success and can begin writing messages using the newly added key.

### Reference implementation

Expand Down
4 changes: 2 additions & 2 deletions docs/reference/warpcast/signers.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ them with the option to Connect with Warpcast.

Your app should generate and securely store an Ed25519 associated with this
user. In the next steps, you will prompt the user to approve this keypair to
signer messages on their behalf.
sign messages on their behalf.

Since this keypair can write to the protocol on behalf of the user it's
important that:
Expand Down Expand Up @@ -61,7 +61,7 @@ const key = '0x' + Buffer.from(publicKeyBytes).toString('hex');
/*** Generating a Signed Key Request signature ***/

const appFid = process.env.APP_FID;
const account = mnemonicToAccount(process.env.APP_MNENOMIC);
const account = mnemonicToAccount(process.env.APP_MNEMONIC);

const deadline = Math.floor(Date.now() / 1000) + 86400; // signature is valid for 1 day
const signature = await account.signTypedData({
Expand Down