feat(macos): add Dock icon setting and fix Hide behavior#3925
Open
WenJiazhi wants to merge 1 commit into
Open
Conversation
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a macOS-only
Keep Dock iconsetting and restore standard Hide behavior.CC Switch remains tray-first by default:
Keep Dock iconis off unless the user enables it. With either setting,Command+H, the app menu Hide command, and KeyClu-triggered Hide now hide the visible main window instead of only moving it behind other windows.Root Cause
On macOS, Tauri/Tao's
set_dock_visibility(false)path setsNSWindow.canHide = false. That breaks AppKit's standardNSApplication.hide(_:)behavior while the app is in no-Dock/accessory mode.Changes
keepDockIconto settings and expose it asKeep Dock iconon macOS.mainWindowVisible && keepDockIcon, preserving the default no-Dock tray behavior in background, silent startup, and lightweight mode.NSWindow.canHide = trueafter applying the Dock policy.Related Issue
Fixes #316.
Related context: #67 documents the intentional no-Dock tray behavior.
Screenshots
Checklist
cargo fmt --checkcargo clippy --no-depsTZ=UTC cargo test --libtsc --noEmitprettier --check "src/**/*.{js,jsx,ts,tsx,css,json}"vitest runvite buildCommand+Hhides the main window withKeep Dock iconoff and on.