Skip to content

[codex] Fix WebDAV saved password placeholder#3973

Open
xwil1 wants to merge 1 commit into
farion1231:mainfrom
xwil1:codex/webdav-password-placeholder
Open

[codex] Fix WebDAV saved password placeholder#3973
xwil1 wants to merge 1 commit into
farion1231:mainfrom
xwil1:codex/webdav-password-placeholder

Conversation

@xwil1

@xwil1 xwil1 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR fixes the WebDAV sync settings password field when a password has already been saved.

Previously, the backend correctly redacted the saved WebDAV password before returning settings to the frontend, but the frontend could only see an empty password value. As a result, the password field looked blank even when a password was already configured.

This change adds a non-sensitive passwordConfigured flag so the frontend can show a masked placeholder (••••••••) without receiving or storing the real password.

What changed

  • Add passwordConfigured to WebDAV sync settings returned to the frontend.
  • Keep the actual WebDAV password redacted before sending settings to the frontend.
  • Show a masked placeholder for saved WebDAV passwords while keeping the input value empty.
  • Remove the previous frontend-only password preservation logic that temporarily kept the typed password in the input after save.
  • Update WebDAV sync settings tests for the redacted saved-password behavior.

Behavior

  • If a WebDAV password is already saved, the password field shows •••••••• as a placeholder.
  • If the user does not edit the password field, saves/tests continue to preserve the existing saved password.
  • If the user enters a new password, the new password is submitted and replaces the saved one.

Scope

This is scoped to the WebDAV sync settings form and settings payload only.

It does not change routing, provider configs, S3 sync, Claude Code, Codex, Gemini, or other client behavior. It also does not expose stored credentials to the frontend.

Validation

  • pnpm test:unit tests/components/WebdavSyncSection.test.tsx
  • pnpm typecheck
  • pnpm format:check
  • cargo fmt --manifest-path src-tauri/Cargo.toml --check
  • git diff --check

@xwil1 xwil1 marked this pull request as ready for review June 9, 2026 15:33
@farion1231

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants