[Refactor] Optimize Sholat Location Upsert and Improve Error Handling with Typed Exceptions#38
Merged
Merged
Conversation
farulivan
commented
May 3, 2026
farulivan
commented
Owner
- Replace loop-based upsert with single batch insert using SQL excluded values
- Add LocationNotFoundError and UpstreamUnavailableError custom error classes
- Enhance fetchJson to catch network errors and distinguish 404 vs 5xx responses
- Replace string-based error detection with instanceof checks for typed errors
- Update tests to use typed error simulation methods
- Only refresh location catalog on Location
…with typed exceptions - Replace loop-based upsert with single batch insert using SQL excluded values - Add LocationNotFoundError and UpstreamUnavailableError custom error classes - Enhance fetchJson to catch network errors and distinguish 404 vs 5xx responses - Replace string-based error detection with instanceof checks for typed errors - Update tests to use typed error simulation methods - Only refresh location catalog on Location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.