-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Armbian version detection and add support for ubuntu-based armbian detection #1447
Refactor Armbian version detection and add support for ubuntu-based armbian detection #1447
Conversation
Ubuntu can be used to build Armbian, it is one of the official bases for Armbian. This allows the detection of Armbian in case it is based on Ubuntu.
Please reuse code of debian flavors. |
The debian-derived detection function doesn't run if the id is Ubuntu, which is the case for an ubuntu-based Armbian image. It will still need to be handled in both Ubuntu and debian variant detection. If you want me to just refactor so that Armbian detection uses a common function in both Ubuntu and debian flavours detection then that's fine, but I don't completely understand what you mean. |
I mean this |
51bf6e3
to
0f95a8b
Compare
0f95a8b
to
61fcbe7
Compare
61fcbe7
to
9130da6
Compare
Alright, refactored the armbian detection. The version detection is in a single function, which also sets |
Thanks. |
Since it's called armbian, I assume it supports only arm32 and aarch64? Is |
While the project was initially aimed at arm SBCs, it currently supports x86_64 as well, and I think I've heard something about risc-v boards. So no, it shouldn't be limited to arm. UPD: the website has images for aarch64, armhf, amd64 and riscv64 |
Ubuntu can be used to build Armbian, it is one of the official bases for Armbian. This allows the detection of Armbian in case it is based on Ubuntu.