Add a cmake option to make flashfetch targets optional #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the `-DBUILD_FLASHFETCH='ON'/'OFF'` build option so one can skip the `flashfetch` target (both from executable and install targets, option at `ON` by default to preserve compatibility with the current default behavior). This is useful when distributing pre-built downstream packages (e.g. for Linux distributions packaging `fastfetch`) as building and shipping the `flashfetch` binary in such pre-built packages serves little to no purpose.
Antiz96
changed the title
|
Thanks! |
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Dec 29, 2024
https://github.com/fastfetch-cli/fastfetch/releases/tag/2.33.0 Tiny improvements made to the APKBUILD: - Use the new `-DBUILD_FLASHFETCH` option to disable building the `flashfetch` binary, which makes little to no purpose being built & shipped in a prebuilt package (see fastfetch-cli/fastfetch#627 & fastfetch-cli/fastfetch#1455, as well as the related note in the above changelog) - Use the `-DBUILD_TEST` option to build tests and tests binaries, allowing to simply use `ctest` during `check()` - Do not specify targets to build during `cmake build` so every needed targets are built (including current and future tests binaries required during `check()`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
-DBUILD_FLASHFETCH='ON'/'OFF'build option so one can skip theflashfetchtarget (both from executable and install targets, option atONby default to preserve compatibility with the current default behavior).This is useful when distributing pre-built downstream packages (e.g. for Linux distributions packaging
fastfetch) as building and shipping theflashfetchbinary in such pre-built packages serves little to no purpose.