Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible buffer overflow in exe path detection #1468

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

peter15914
Copy link
Contributor

-1 is a possible return value of readlink().
This leads to accessing the array exePath with a negative index.

On error, -1 is returned from readlink()
@peter15914 peter15914 marked this pull request as ready for review December 28, 2024 21:28
@CarterLi CarterLi merged commit 2a83b86 into fastfetch-cli:dev Dec 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants