-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More automated tests #152
Merged
Merged
More automated tests #152
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
677fffe
started writing a couple of automated tests to chip in, working towar…
c0eff10
added a couple more tests and eslint fixes
49daf3a
added all the cases for the basename
b912269
better test description
2bf1a01
added the plan for the subtest too in the dicer-write.test.js
2700550
PR review: removed the t.end() in dicer-write.test.js
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
'use strict' | ||
|
||
const { test } = require('tap') | ||
const basename = require('../lib/utils/basename') | ||
|
||
test('basename', (t) => { | ||
t.plan(3) | ||
|
||
t.test('returns an empty string if the path is not a string', (t) => { | ||
const result = basename({}) | ||
|
||
t.equal(result, '') | ||
t.end() | ||
}) | ||
|
||
t.test('returns an empty string if the path includes a \' and the char after is a .', (t) => { | ||
const result = basename('path\\.') | ||
|
||
t.equal(result, '') | ||
t.end() | ||
}) | ||
|
||
t.test('returns an empty string if the path is a .', (t) => { | ||
const result = basename('.') | ||
|
||
t.equal(result, '') | ||
t.end() | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
'use strict' | ||
|
||
const Busboy = require('../lib/main') | ||
const { test } = require('tap') | ||
|
||
test('busboy, emit', t => { | ||
t.plan(1) | ||
|
||
t.test('returns undefined when the event is called a second time and the busboy was already finished', t => { | ||
const busboy = new Busboy({ headers: { 'content-type': 'application/x-www-form-urlencoded' } }) | ||
busboy._finished = true | ||
busboy.emit('finish') | ||
|
||
t.equal(busboy.emit('finish'), undefined) | ||
t.end() | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
'use strict' | ||
|
||
const { test } = require('tap') | ||
const { Dicer } = require('../lib/main') | ||
|
||
test('dicer _write method', t => { | ||
t.plan(1) | ||
|
||
t.test('the PartStream instance is created only once if the _write method is called more than once', t => { | ||
const dicer = new Dicer({ headerFirst: true }) | ||
|
||
dicer._write(Buffer.from('Content-Type: text/plain'), null, () => { | ||
dicer._write(Buffer.from('Content-Type: text/plain'), null, () => { | ||
t.pass('write method called') | ||
}) | ||
}) | ||
|
||
t.end() | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
'use strict' | ||
|
||
const Multipart = require('../lib/types/multipart') | ||
const Busboy = require('../lib/main') | ||
const { test } = require('tap') | ||
|
||
test('multipart constructor', t => { | ||
t.plan(1) | ||
|
||
t.test('throws if the boundary is not a string', t => { | ||
const busboy = new Busboy({ headers: { 'content-type': 'application/x-www-form-urlencoded' } }) | ||
|
||
t.throws(() => new Multipart(busboy, { boundary: 123 }), new Error('Multipart: Boundary not found')) | ||
t.end() | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically not testing anything, because you call t.end(). use t.plan for this subtest also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Uzlopak oh, good to know! First time using this testing framework!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the t.end() please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Uzlopak is there anything else for me to do in this PR?