fix(types): export function definition types#65
Merged
Uzlopak merged 2 commits intofastify:masterfrom Jan 27, 2025
Merged
Conversation
mcollina
reviewed
Jan 23, 2025
Member
mcollina
left a comment
There was a problem hiding this comment.
Thanks for opening a PR! Can you please add a unit test? We use tsd for types.
Contributor
Author
@mcollina Tests added 🙂 |
Uzlopak
approved these changes
Jan 27, 2025
Contributor
Uzlopak
left a comment
There was a problem hiding this comment.
I guess exporting the types wont harm ;)
gurgunday
approved these changes
Jan 27, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12.
While working on one of my private projects, I encountered the same issue described in #12.
I’m using deepmerge with TypeScript, and when building my project, I experienced the heap out of memory error mentioned in that issue.
To resolve this, I tried exporting
DeepMergeFnandDeepMergeAllFndirectly from the@fastify/deepmergefolder innode_modules, which successfully fixed the problem.Alternatively, if the issue persists, you can leverage these types as follows:
Checklist
npm run testandnpm run benchmarkand the Code of conduct