Skip to content

feat: make isMergeableObject configurable#68

Merged
mcollina merged 6 commits intomainfrom
expose-isMergeableObject
Apr 2, 2025
Merged

feat: make isMergeableObject configurable#68
mcollina merged 6 commits intomainfrom
expose-isMergeableObject

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Feb 6, 2025

Missing docs yet

@benjamin-stern
Copy link
Contributor

@Uzlopak would it be possible to export defaultIsMergeableObject so that it can be built upon?

@Fdawgs Fdawgs linked an issue Feb 7, 2025 that may be closed by this pull request
2 tasks
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

@Uzlopak can you add the docs?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Mar 27, 2025

Yes

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Mar 31, 2025

@mcollina
PTAL

@benjamin-stern
PTAL

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Aras Abbasi <[email protected]>
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Mar 31, 2025

@benjamin-stern

Just for your information: The exported default IsMergeableObject function is not overrideable or so. I did not want that somebody is able to manipulate it by doing some "smart" manipulation.

Co-authored-by: Frazer Smith <[email protected]>
Signed-off-by: Aras Abbasi <[email protected]>
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Mar 31, 2025

@Fdawgs

Thank you :)

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a55ac2e into main Apr 2, 2025
13 checks passed
@mcollina mcollina deleted the expose-isMergeableObject branch April 2, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export private isMergeableObject

5 participants