Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create basic architecture #1
Create basic architecture #1
Changes from all commits
f280c16
215955f
7f7392c
39c46b7
1eca5f7
a707ce9
0289553
a382257
36156f4
bbc21ac
fa32133
5da2429
1494030
8ea43b3
1f899f7
54807be
006ccd1
5ed556f
d48b86c
d8101c4
d41849b
84bf9f9
b4981ed
05ffbab
3d58075
31d0e15
0a91f6b
6653a37
1baf9b7
4cbf9c2
10e8571
7d0829e
45cf1cb
f0f8d5c
727d5e2
57dce97
2c5595c
6859421
607910f
67f12f7
1f4d3c8
33f5fcc
30a7a57
bc83e71
e61a1b7
f0c8645
540e60a
08076bf
afa52ec
e4dce34
c7379ab
831d593
243b2e0
ec1230a
9e3fcd6
b022486
58e0380
d7c2cd3
fb902bc
a39812c
a460b70
7d1a0e9
a43ea65
04c1b13
2cd901d
9993ede
c4fac81
7110c13
5502682
238698a
66f3664
f88fd1c
5529b8d
0ea8f26
3703d87
02ffde1
fb82c1e
e5a6775
256bb38
a15de0b
6c24c39
81d5950
a84e0a3
dfde7ee
abe4809
3ad48a0
044baea
e1ee800
0366dac
8897a41
ec8005f
3a6dfa5
95a1b1d
776086b
59d9484
6bce950
c2c0f86
5cd29c8
4031f28
26acff6
ccbecd4
1e16652
c6e7cd9
43136ed
1af3f0a
8fb8618
6eb86ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be nice here to develop a bit more about the methodology or decisions made that lead to this repository; that backstory sometimes helps companies to decide wether or not to adopt a given technology (I've faced that in the past)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe explain which Fastify plugins are part of this demo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to maintain a list of plugins used in the doc.
To be honest, I'm not really sure what the documentation should contain, although I'm aware that I should be working on it. IMO, I think it should be very minimalist, explaining the purpose of the demo and how to configure the application. The purpose of the demo is to show concrete code, so people should look at the code and comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK then not