Skip to content

perf: avoid addComma when not necessary #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

perf: avoid addComma when not necessary #802

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f884f2
perf: avoid addComma on empty array
cesco69 Oct 8, 2025
5fde9b6
perf: avoid other addComma
cesco69 Oct 8, 2025
6932828
fix: lint
cesco69 Oct 8, 2025
a1fade3
fix: compliant with json schema
cesco69 Oct 8, 2025
c8a0a47
feat: add test
cesco69 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ function buildInnerObject (context, location) {
code += 'let json = JSON_STR_BEGIN_OBJECT\n'

let addComma = ''
if (!hasRequiredProperties) {
if (!hasRequiredProperties && (propertiesKeys.length > 1 || (schema.patternProperties || schema.additionalProperties))) {
code += 'let addComma = false\n'
addComma = '!addComma && (addComma = true) || (json += JSON_STR_COMMA)'
}
Expand Down