Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enabled Node 12 on Travis #44

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Re-enabled Node 12 on Travis #44

merged 2 commits into from
Jun 25, 2019
+1 −0

Conversation

MichielDeMey
Copy link
Contributor

@MichielDeMey MichielDeMey commented Feb 12, 2019 •
edited
Loading

Re-enabling Node 12 on Travis, attempt to fix #40

@mcollina
Copy link
Member

https://travis-ci.org/fastify/fastify-postgres/jobs/492216929 < here is the failure

darkgl0w
darkgl0w suggested changes Jun 25, 2019
View reviewed changes
Copy link
Member

@darkgl0w darkgl0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready to be merged with a little nit. ❤️

@MichielDeMey @darkgl0w
Bump to Node 12
e7119e1 
Co-Authored-By: darkgl0w <31093081+darkgl0w@users.noreply.github.com>
@MichielDeMey MichielDeMey changed the title Re-enabled Node 11 on Travis Re-enabled Node 12 on Travis Jun 25, 2019
@MichielDeMey
Copy link
Contributor Author

Tests are passing! 😎

Eomm
Eomm approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darkgl0w fixed travis 😂

@MichielDeMey
Copy link
Contributor Author

Let’s merge this massive PR! 🏋️‍♂️😂

mcollina
mcollina approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 4aaedd1 into fastify:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkgl0w darkgl0w

@mcollina mcollina

@Eomm Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests failing on Node 11 on travis
4 participants
@MichielDeMey @mcollina @Eomm @darkgl0w