Skip to content

Safely access schema to prevent crashes #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

makrandgupta
Copy link

Checklist

Hey, I just set up swagger on my repo and it kept crashing when trying to resolve params and path. This has fixed the issue for me. Wanted to put up this PR in case this is truly a bug. Tests are passing but dont see a benchmark script.

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide an unit test for the PR.

@makrandgupta
Copy link
Author

I think the tests would go in test/spec/openapi/route.js. But I am not sure how to capture the change above in the way those tests are written. I could use some help here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants