Skip to content

Commit

Permalink
chore: exclude Node 14 and 16 on macos (#127) (#128)
Browse files Browse the repository at this point in the history
* chore: exclude Node 14 and 16 on macos

Related to fastify/.github#37.

This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations



* remove os matrix from package

---------

Signed-off-by: Simone Busoli <[email protected]>
  • Loading branch information
gurgunday authored Apr 29, 2024
1 parent 758b570 commit 0540c8a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/plugins-ci-package-manager.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,18 @@ on:
jobs:
pnpm:
name: pnpm
runs-on: ${{ matrix.os }}
runs-on: ubuntu-latest
permissions:
contents: read
strategy:
matrix:
node-version: [16, 18, 20, 21]
os: [ubuntu-latest]
pnpm-version: [8]
# pnpm@8 does not support Node.js 14 so include it separately
include:
- node-version: 14
os: ubuntu-latest
pnpm-version: 7

steps:
- name: Check out repo
uses: actions/checkout@v4
Expand All @@ -44,13 +42,12 @@ jobs:

yarn:
name: Yarn
runs-on: ${{ matrix.os }}
runs-on: ubuntu-latest
permissions:
contents: read
strategy:
matrix:
node-version: [14, 16, 18, 20]
os: [ubuntu-latest]
steps:
- name: Check out repo
uses: actions/checkout@v4
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/plugins-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ jobs:
exclude:
- os: windows-latest
node-version: 14
- os: macos-latest
node-version: 14
- os: macos-latest
node-version: 16
steps:
- name: Check out repo
uses: actions/checkout@v4
Expand Down

0 comments on commit 0540c8a

Please sign in to comment.